Skip to content

Conversation

@westeezy
Copy link

@westeezy westeezy commented Feb 4, 2026

Description

Allow hosts to specify color scheme preference (light/dark/auto) when loading embedded checkout, enabling visual consistency with host apps.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as expected, including removal of schema files
    or fields
    )
  • Documentation update

Is this a Breaking Change or Removal?

If you checked "Breaking change" above, or if you are removing any schema
files or fields:

  • I have added ! to my PR title (e.g., feat!: remove field).
  • I have added justification below.
## Breaking Changes / Removal Justification

(Please provide a detailed technical and strategic rationale here for why this
breaking change or removal is necessary.)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@westeezy westeezy requested a review from a team February 4, 2026 21:52
@google-cla
Copy link

google-cla bot commented Feb 4, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lemonmade lemonmade added the TC review Ready for TC review label Feb 5, 2026
@lemonmade lemonmade added this to the Working Draft milestone Feb 5, 2026
@785479311tb
Copy link

Breaking Changes / Removal Justification

(Please provide a detailed technical and strategic rationale here for why this
breaking change or removal is necessary.)

Copy link
Contributor

@igrigorik igrigorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more suggestions.

Allow hosts to specify color scheme preference (light/dark/auto) when loading embedded checkout, enabling visual consistency with host apps.
@westeezy westeezy force-pushed the feature/ec_color_scheme branch from 3e68d72 to 08c636c Compare February 11, 2026 01:42
@westeezy
Copy link
Author

Thanks for the suggestions @igrigorik! I applied all requested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TC review Ready for TC review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants