-
Notifications
You must be signed in to change notification settings - Fork 267
feat: add ec_color_scheme query parameter to embedded checkouts #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add ec_color_scheme query parameter to embedded checkouts #157
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Breaking Changes / Removal Justification(Please provide a detailed technical and strategic rationale here for why this |
igrigorik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more suggestions.
Allow hosts to specify color scheme preference (light/dark/auto) when loading embedded checkout, enabling visual consistency with host apps.
3e68d72 to
08c636c
Compare
|
Thanks for the suggestions @igrigorik! I applied all requested changes |
Description
Allow hosts to specify color scheme preference (light/dark/auto) when loading embedded checkout, enabling visual consistency with host apps.
Type of change
Please delete options that are not relevant.
functionality to not work as expected, including removal of schema files
or fields)
Is this a Breaking Change or Removal?
If you checked "Breaking change" above, or if you are removing any schema
files or fields:
!to my PR title (e.g.,feat!: remove field).Checklist